Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4

Merged
merged 3 commits into from Nov 15, 2012
Merged

Fixes #4

merged 3 commits into from Nov 15, 2012

Conversation

jbinary
Copy link
Contributor

@jbinary jbinary commented Nov 15, 2012

Thanks for the project.

I have a few fixes for you, could you review them?

Also, I added possibility to use another email backend in addition to this, this way the project can be used to log sent letters. Didn't know if you need it so created a separate branch for fixes.

@stefanfoulis
Copy link
Owner

thanks!
fyi there already is a project that allows defining multiple email backends: https://github.com/KristianOellegaard/django-multiple-email-backends

stefanfoulis added a commit that referenced this pull request Nov 15, 2012
@stefanfoulis stefanfoulis merged commit 6dbd3f1 into stefanfoulis:develop Nov 15, 2012
@jbinary
Copy link
Contributor Author

jbinary commented Nov 16, 2012

Thanks for the link!

Unfortunately, that project is not suitable for me because it'll log each message even if the second backend couldn't send some of them. Instead of that, my solution logs only those message that were actually sent through the smtp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants