Update modelfields.py to address Issue #123 #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch to get_prep_value() allows manage.py migrate to successfully complete. This is to address issue "Running migration on phonenumberfield results in AttributeError stefanfoulis#123" As per https://docs.djangoproject.com/en/1.8/howto/custom-model-fields/#custom-field-deconstruct-method, I also added the deconstruct method. I don't know if my migration will run without this, but figure since it's required, it should stay.
Update modelfields.py
|
Changes Unknown when pulling 608b028 on dedayoa:develop into * on stefanfoulis:develop*. |
| @@ -73,6 +73,10 @@ def get_prep_value(self, value): | |||
| return value | |||
| format_string = getattr(settings, 'PHONENUMBER_DB_FORMAT', 'E164') | |||
| fmt = PhoneNumber.format_map[format_string] | |||
|
|
|||
| if value is None: | |||
| return '' | |||
There was a problem hiding this comment.
What if a field has null=True? Shouldn't it return None then?
|
Hi @dedayoa, I cannot refer to your problem not having a piece of your code. I've already commented your changes and I'm not very convinced to your PR. Are you sure that it is not a bug in your application? Recently we have changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch to get_prep_value() allows manage.py migrate to successfully complete. This is to address issue "Running migration on phonenumberfield results in AttributeError #123"
As per https://docs.djangoproject.com/en/1.8/howto/custom-model-fields/#custom-field-deconstruct-method, I also added the deconstruct method. I don't know if my migration will run without this, but figure since it's required, it should stay.