Fixed Firefox bug that broke the timepicker. #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefangabos
added a commit
that referenced
this pull request
Sep 26, 2019
|
I applied a different fix for this one - see 9fa97b5 |
|
Looks like the auto incrementing functionality no longer works. See https://stefangabos.github.io/Zebra_Datepicker/#time |
stefangabos
added a commit
that referenced
this pull request
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time control element is removed from the DOM and in Firefox the element does not have ".Zebra_Datepicker" as a parent, because it's no longer part of the DOM. By adding this extra condition, everything still works without any masive refactoring. In Chrome the element is removed from the DOM after the condition is verified, that's why this works in Chrome.
An alternative would be to rethink the code so that the DOM is not rewritten every time the date/time changes.