-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive #8
Comments
You'll have to use the |
If it needs customizing it shouldn't be declared as responsive in the description. |
|
Adding @media (max-width: 574px) {
width: 100%;
} to |
Sounds great. |
Sounds good, I will add that also |
👍 |
I have also seen, that the calculation of the dialog/modal position seems to calculate negative top positions, if the modal is higher than the viewport. |
I can confirm this. I'm fighting with this issue (dialog height exceeds display height) right now. Will check if the max-height does the trick here too. |
Will fix this week
…On Jul 3, 2017 12:49, "Discotizer" ***@***.***> wrote:
I can confirm this. I'm fighting with this issue (dialog height exceeds
display height) right now. Will check if the max-height does the trick here
too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtPLc1XPMy032ajzwpuuFbo9xTUdGoRks5sKLkcgaJpZM4OHCOE>
.
|
Guys, is this ok now, can I close it? |
I will check |
Yes, this works for me! Thanks for the fix. |
It's still exceeding the viewport height. |
Make sure you are downloading the latest commit and not the release |
I have tested with the raw dist files, but I will test again and give you feedback |
Could you please tell me in which way the modal dialog boxes are responsive as mentioned in the description?
Within the css the dimensions are defined with pixel values and there are also no media queries
Also when testing it with the demo code on mobile phones it is breaking the viewport.
The text was updated successfully, but these errors were encountered: