Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Requests (Croatian, Serbian, Slovene) #73

Closed
AppyxDaniel opened this issue Jan 27, 2023 · 9 comments
Closed

Language Requests (Croatian, Serbian, Slovene) #73

AppyxDaniel opened this issue Jan 27, 2023 · 9 comments

Comments

@AppyxDaniel
Copy link

Hi,

is it possible to add the following languages?

If not, what would need to be done in order to add those languages?

Thanks in advance!

@stefangabos
Copy link
Owner

For Croatian I'll have to update my script first as it currently expects tables. I'll update it so that it can also read lists like that. Afterwards I will be able to tell if something is missing or not.

The following are missing for Serbian

Bonaire, Sint Eustatius and Saba, bq, 535, bes
Curaçao, cw, 531, cuw
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Sint Maarten (Dutch part), sx, 534, sxm
South Sudan, ss, 728, ssd
Sudan, sd, 729, sdn]

For Slovene, the following are missing

Bonaire, Sint Eustatius and Saba, bq, 535, bes
Curaçao, cw, 531, cuw
Guernsey, gg, 831, ggy
Isle of Man, im, 833, imn
Jersey, je, 832, jey
Montenegro, me, 499, mne
Saint Barthélemy, bl, 652, blm
Saint Martin (French part), mf, 663, maf
Serbia, rs, 688, srb
Sint Maarten (Dutch part), sx, 534, sxm
Sudan, sd, 729, sdn

In all cases, note that there s Sudans

728 => array('id' => 728, 'alpha2' => 'ss', 'alpha3' => 'ssd', 'name' => 'South Sudan'),
729 => array('id' => 729, 'alpha2' => 'sd', 'alpha3' => 'sdn', 'name' => 'Sudan'),

@AppyxDaniel
Copy link
Author

Updated the sources for Serbian and Slovene. Please check again.

@stefangabos
Copy link
Owner

I've checked and both look good!
I'll add them over the weekend and will try to make time for updating my script so that we can check Croatian.
Thanks a lot for you work!

@stefangabos
Copy link
Owner

I found one thing
In Slovenian, the numeric code for Srbija needs to be 688 instead of 891

@AppyxDaniel
Copy link
Author

Oh sorry, I did not double check for duplicate names. Srbija existed twice in this list: once with 891 (Serbia and Montenegro) and one with 688. Since Serbia and Montenegro are now two separate entries, I removed the 891

@stefangabos
Copy link
Owner

Thanks for the quick update, I added both languages and published a new release.
I'll try to find time over the weekend for adding the Croatian language.
Please drop me a comment if you don't hear from me over the weekend as I tend to forget :) I am managing a lot of open source projects, work and family :)
Thanks again!

@stefangabos
Copy link
Owner

For Croatian

The following are missing

AX Åland Islands
BQ Bonaire, Sint Eustatius and Saba
CW Curaçao
PS Palestine, State of
BL Saint Barthélemy
MF Saint Martin (French part)
SX Sint Maarten (Dutch part)
SS South Sudan

The following need to be removed

AN Nizozemski Antili
TB Tibet

@AppyxDaniel
Copy link
Author

Please check again. I updated the source.

@stefangabos
Copy link
Owner

I added Croatian and made a new release.
Thanks a lot for you contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants