Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix simplified Chinese and traditional Chinese mix #32

Closed
wants to merge 7 commits into from

Conversation

sun-jiao
Copy link

No description provided.

@sun-jiao
Copy link
Author

sun-jiao commented Apr 23, 2020

I saw your comment in another pull request, you have a script, but I don't know if your script get data from wiki code or the webpage.

The Chinese Wikipedia can auto convert between traditional and simplified Chinese, so the country names in wiki code may be mixed.(and it's not allowed to change between them.) If your script get data from webpage, that will be great, you should just change the target URL to a concerted page. If you get data from wiki code, a manual conversion will be needed.

@stefangabos
Copy link
Owner

This is the link from where I am taking country names. Obviously, I take the country names by parsing the HTML code in the page, but whatever you see is the same as what there is in the page's code.

@stefangabos
Copy link
Owner

Can you please give me a link to that page set up so that it shows what I need to parse?

@stefangabos
Copy link
Owner

Apparently what I see when I am accessing the page is in - according to Google Translate - Chinese (Traditional)

@stefangabos
Copy link
Owner

Additionally, switching via Google Translate from traditional to simplified Chinese makes no difference in country names - at least that is how it seems to me

@sun-jiao
Copy link
Author

This is the link from where I am taking country names. Obviously, I take the country names by parsing the HTML code in the page, but whatever you see is the same as what there is in the page's code.

Simplified Chinese:
https://zh.wikipedia.org/zh-cn/ISO_3166-1

@stefangabos
Copy link
Owner

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

@stefangabos stefangabos reopened this Apr 24, 2020
@sun-jiao
Copy link
Author

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

I think it's a good idea to add zh-tw and zh-hk version, and no need to add other variants.
https://zh.wikipedia.org/zh-tw/ISO_3166-1
https://zh.wikipedia.org/zh-hk/ISO_3166-1

zh-mo is almost same as zh-hk. zh-my and zh-sg are almost same as zh-cn.
Can you please update the cn version again? I just updated the simplified Chinese name of 876,wf,wlf in Wikipedia.

@sun-jiao
Copy link
Author

done. do i have to include other variations of the Chinese language? Like zh-tw, zh-hk, zh-mo, zh-my, etc. ? if so, which ones should I add? thank you for helping!

btw, Would you like to add svg version of flags? You can get filenames of them from the html, and find them in wikimedia commons.

@stefangabos
Copy link
Owner

stefangabos commented Apr 24, 2020

i have reprocessed the wikipedia page and updated the country name for the one you changed.
i will also include the other variations of the chinese language in the coming days.
good idea about the svg flags, i will also look into that.
thanks a lot for all your support!

@sun-jiao
Copy link
Author

i have reprocessed the wikipedia page and updated the country name for the one you changed.
i will also include the other variations of the chinese language in the coming days.
good idea about the svg flags, i will also look into that.
thanks a lot for all your support!

Thank you for this pleasant discussion and for your excellent project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants