-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for custom router implementations #13
Labels
enhancement
New feature or request
Comments
Yes, it would look even better this way. |
stefanhoelzl
added a commit
that referenced
this issue
Jun 22, 2020
stefanhoelzl
added a commit
that referenced
this issue
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@vadolasi made in #12 the proposal to support custom vue router implementations.
An example how to use such a implementation with vue.js is shown here
parameter proposal
The initial proposal looks like this
using this would look like this
class attribute proposal
another proposal could look like this
using this would look like this
The advantage of the
class attribute proposal
would be that the definition of the custom implementation and the declaration of the actual Router class is together.This means by looking at the
Router
implementation it can be understood completely.And it is also closer to the definition of other vue.py objects, where most of the functionality is described by class attributes/methods.
In the other proposal to understand the whole Router implementation someone also has to look at the App initialization.
So I would propose to implement the
class attribute proposal
.@vadolasi does this work for your use case?
The text was updated successfully, but these errors were encountered: