Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all-stars to reduce duplicates and provide more author info #6

Closed
nexdrew opened this issue Nov 6, 2015 · 3 comments
Closed

Use all-stars to reduce duplicates and provide more author info #6

nexdrew opened this issue Nov 6, 2015 · 3 comments

Comments

@nexdrew
Copy link
Contributor

nexdrew commented Nov 6, 2015

Based on conversation here and similar idea here, I created all-stars which contains pre-fetched author data for the maintainers of the top depended packages on npm. Credits could leverage this to achieve the following, without hitting the network or sacrificing speed:

  1. Remove duplicate listings of some popular authors

    So that, e.g., the following can be identified as the same person and grouped/listed once:

    jonschlinkert github@sellside.com (12 packages)
    Jon Schlinkert (12 packages)
    ...
    Isaac Z. Schlueter i@izs.me (19 packages)
    isaacs isaacs@npmjs.com (7 packages)
    ...
    juliangruber julian@juliangruber.com (4 packages)
    Julian Gruber mail@juliangruber.com (4 packages)
    ...
    jonathanong jonathanrichardong@gmail.com (3 packages)
    Jonathan Ong me@jongleberry.com (2 packages)
    
  2. Provide more info, like GitHub username, for several authors

    E.g. something like this (or credits-cli could just use a different style for GitHub usernames):

    Isaac Z. Schlueter isaacs@npmjs.com [GitHub: isaacs] (26 packages)
    Jon Schlinkert github@sellside.com [GitHub: jonschlinkert] (24 packages)
    Julian Gruber julian@juliangruber.com [GitHub: juliangruber] (8 packages)
    Jonathan Ong jonathanrichardong@gmail.com [GitHub: jonathanong] (5 packages)
    

The initial release of all-stars includes data for 251 authors of the top 150 depended packages.

Please take a look and let me know what you think. Thanks!

@stefanjudis
Copy link
Owner

Hmm... Interesting. :)

What should happen to the people that are not included in all-stars?

I will check you project in detail soon, I've got a lot to do on the weekend. ;) Please feel free to ping me again, when you haven't heard something after a few days. :)

@nexdrew
Copy link
Contributor Author

nexdrew commented Nov 7, 2015

For maintainers that are not found in all-stars, I would just stick with the current functionality - no gain or loss there.

Over time, PRs could be created against all-stars to add missing folks - no changes to credits would be required at that point (besides maybe bumping the dependency). 😎

@stefanjudis
Copy link
Owner

Closed with #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants