Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider the following #96

Open
2 of 6 tasks
Hypercubed opened this issue Oct 12, 2016 · 3 comments
Open
2 of 6 tasks

Please consider the following #96

Hypercubed opened this issue Oct 12, 2016 · 3 comments

Comments

@Hypercubed
Copy link
Collaborator

Hypercubed commented Oct 12, 2016

A few suggestions I think we can consider:

  • Use eslint-plugin-node to ensure post node v4 features are not accidentally added. (see eslint-plugin-node #97)
  • Get the package name from the name attribute instead of the folder name. (see wip)
  • Each analyzer should return a promise. (see wip)
  • Migrate from eslint with custom rules to xo.
  • Migrate from ava to jest. (For snapshot feature).
  • Support component.json
@Hypercubed Hypercubed changed the title Considering the following improvements: Please consider the following Oct 12, 2016
@adam-golab
Copy link
Contributor

I started working on a migration from ava to jest

@stefanjudis
Copy link
Owner

@adam-golab

Thanks for doing that! 🎉

May I ask what the benefits are in this case over Ava? I haven't worked with Jest yet but know it's great for snapshot testing in react. Does this apply here?

Side note: I don't think I have time to maintain this repo anymore. Happy to give you access if you want to contribute. :)

@adam-golab
Copy link
Contributor

Jest has a lot more features built-in. So, there is no need for adding any plugins. I really like jest's mocking functionality. You can mock almost anything and test only what's needed.

Regarding snapshot testing, it's great, but currently, ava has this feature as well in the newest version. It works very well with React components as well as with just regular JS types. So, if you want to migrate only for snapshot testing I think it will be better to just update ava :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants