Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render icon and menu when app is started in an offline state #13

Open
adamwatters opened this issue Feb 16, 2019 · 4 comments
Open

Render icon and menu when app is started in an offline state #13

adamwatters opened this issue Feb 16, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@adamwatters
Copy link
Contributor

adamwatters commented Feb 16, 2019 •
edited
Loading

The initial render of the app is held up until an online connection is detected. I think the expected UX is for the app to visibly start up even when offline.

how it looks now
image

how I think it should look
image
@adamwatters adamwatters reopened this Feb 16, 2019
@stefanjudis
Copy link
Owner

I agree here but dont think its a big issue though. I went the easy route to not bloat the code. 🙈

Happy to take fixes. 😊

@adamwatters
Copy link
Contributor Author

of course! definitely not a big issue. just flagging it as another place to tinker after I finish #11

@stefanjudis
Copy link
Owner

stefanjudis commented Feb 18, 2019 •
edited
Loading

Looking forward to your contribution! hopefully, the code is not too messy. TypeScript gave me a hard time. 🙈

@adamwatters
Copy link
Contributor Author

lol don't sweat it - it's my first time with TypeScript too!

@stefanjudis stefanjudis added enhancement New feature or request help wanted Extra attention is needed labels Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanjudis @adamwatters