Add support for preserving Unicode characters in jsonpatch CLI #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the JSON content contains some Unicode characters, the jsonpatch
final output will encode the Unicode character using ASCII (i.e
`\u0394`). This behaviour comes from the module `json.dump()` governed
by a flag `ensure_ascii`[1].
For example:
```json
/* patch.json */
[{
"op": "add",
"path": "/SomeUnicodeSamples",
"value": "𝒞𝘋𝙴𝓕ĢȞỈ𝕵 đ áê 🤩 äÄöÖüÜß"
}]
```
After applying the patch on an empty source file `{}`, this is the
output:
```json
{"SomeUnicodeSamples": "\ud835\udc9e\ud835\ude0b...\u00fc\u00dc\u00df"}
```
This commit adds a flag `-u|--preserve-unicode` in the jsonpatch CLI
to configure the behaviour of `json.dump`'s `ensure_ascii` flag.
Using the `--preserve-unicode` flag, the cli will print the Unicode
characters as-is without any encoding.
[1]: https://docs.python.org/3/library/json.html#basic-usage
|
Looks good, thanks :) |
This was referenced Mar 11, 2021
hirmiura
added a commit
to hirmiura/python-json-patch
that referenced
this pull request
Jun 8, 2023
stefankoegl
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the JSON content contains some Unicode characters, the jsonpatch
final output will encode the Unicode character using ASCII (i.e
\u0394). This behaviour comes from the modulejson.dump()governedby a flag
ensure_ascii1.For example:
After applying the patch on an empty source file
{}, this is theoutput:
{"SomeUnicodeSamples": "\ud835\udc9e\ud835\ude0b...\u00fc\u00dc\u00df"}This commits add a flag
-u|--preserve-unicodeinto the jsonpatch CLIto configure the behaviour of
json.dump'sensure_asciiflag.Using the
--preserve-unicodeflag, the final output will print theUnicode characters as-is without any encoding.