Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if there is no diff print nothing, and exit 2 if a diff is found #53

Merged
merged 2 commits into from Oct 2, 2016

Conversation

gergnz
Copy link
Contributor

@gergnz gergnz commented Aug 24, 2016

To mimic grep and other *nix tools exit non-zero (2 I picked) if a difference is found. Also print nothing (not even an empty list) if there is no difference.

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling c25f76f on gergnz:non-zero-exit into 55e0c43 on stefankoegl:master.

@stefankoegl
Copy link
Owner

Hi! Thanks for your contribution :) Is there any precedence for returning 2? I'm asking because it seems kind of arbitrary to me.

@gergnz
Copy link
Contributor Author

gergnz commented Sep 6, 2016

Hi @stefankoegl, it was totally arbitrary. I'm happy to take suggestions on a different exit code.

@gergnz
Copy link
Contributor Author

gergnz commented Sep 6, 2016

A colleague of mine showed me this http://tldp.org/LDP/abs/html/filearchiv.html#DIFFERR2. I'll change to a 1 and push.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling 40f76c9 on gergnz:non-zero-exit into 55e0c43 on stefankoegl:master.

@stefankoegl stefankoegl merged commit 4e95310 into stefankoegl:master Oct 2, 2016
@stefankoegl
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants