Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on labels to collapse/expand groups #52

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

Istador
Copy link
Contributor

@Istador Istador commented Aug 11, 2019

This commit fixes #51

@stefanocudini
Copy link
Owner

good idea

@stefanocudini stefanocudini merged commit adebe6e into stefanocudini:master Dec 23, 2019
@Istador
Copy link
Contributor Author

Istador commented Dec 24, 2019

Ah, good to see that you're back. I assumed the project to be dead after about four months of inactivity and forked it.


You might want to integrate Istador@5477189 (don't merge it directly, because I changed other things too). It adds a new optional option groupCheckboxes, that when set to true adds indeterminate checkboxes to the group label to select/deselect all layers in a group at once. A demonstration of it can be seen here: https://pine.blackpinguin.de/

I took that feature from the other fork https://github.com/syonfox/leaflet-panel-layers, that also changed a few other things that were incompatible with my project (e.g. moving the checkboxes to the left where they collide visually with the layer icons).


I also updated the dependencies to newer versions of grunt. See the changes to the Gruntfile.js and the package.json at Istador@9138d27 (one of the dependencies, uglify or cssmin, doesn't support the banner option anymore, so I changed it to use grunt-banner instead).

@stefanocudini
Copy link
Owner

hi @Istador
I have had serious health problems unfortunately :-/
now I will go back to reading the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on labels to collapse/expand groups
2 participants