Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module examples to the Naming Conventions page as well as a table ... #482

Closed
wants to merge 1 commit into from

Conversation

alexmays
Copy link
Contributor

...for folder naming conventions.

Just some explicit examples, could probably use some re-touching.

Signed-off-by: Alexander Mays alex@astonishdesign.com

…le for folder naming conventions.

Signed-off-by: Alexander Mays <alex@astonishdesign.com>
@stefanpenner
Copy link
Owner

this looks fantastic, thanks!

@stefanpenner
Copy link
Owner

can you ad an example with nested folders? controllers/foo/bar-baz.js or something? I think that was the scenario left out

@alexmays
Copy link
Contributor Author

Sure thing, I'm going to continue to refactor them a bit, that was just something I was able to put out on Friday evening after work.

Alexander Mays
Astonish Design | 512-553-6830

On Feb 10, 2014, at 9:32 AM, Stefan Penner notifications@github.com wrote:

this looks fantastic, thanks!


Reply to this email directly or view it on GitHub.

@stefanpenner
Copy link
Owner

sounds good, can you make a checklist so i know when you are done, so i know when i can merge?

@alexmays
Copy link
Contributor Author

We can disregard this pull request and I'll submit a new one later today.

Alexander Mays
Astonish Design | 512-553-6830

On Feb 10, 2014, at 9:50 AM, Stefan Penner notifications@github.com wrote:

sounds good, can you make a checklist so i know when you are done, so i know when i can merge?


Reply to this email directly or view it on GitHub.

@alexmays
Copy link
Contributor Author

As far as sweeping changes to the docs, what is your recommendation? I feel like it could be consolidated/rearranged in a more coherent manner.

Alexander Mays
Astonish Design | 512-553-6830

On Feb 10, 2014, at 9:50 AM, Stefan Penner notifications@github.com wrote:

sounds good, can you make a checklist so i know when you are done, so i know when i can merge?


Reply to this email directly or view it on GitHub.

@MajorBreakfast
Copy link
Contributor

We opted for dasherized file names in #218, didn't we? As Stefan put it: One naming convention for file and module names. I'd really like that anyway.

@MajorBreakfast
Copy link
Contributor

Now I had a closer look at your changes. It seems that it's just mixed. The resolver supports both naming conventions but it would be nice to stick with dashes in the docs. What do you think? Thanks for your effort btw :)

@stefanpenner
Copy link
Owner

+1 for consistency

@stefanpenner
Copy link
Owner

@alexmays you can reuse existing pull requests? this keeps noise down

@stefanpenner
Copy link
Owner

@alexmays ping, would love to get this rebase + in.

@alexmays
Copy link
Contributor Author

I apologize, I still have some pending changes. I'll get this done after work tonight!

@alexmays alexmays closed this Mar 3, 2014
@alexmays
Copy link
Contributor Author

alexmays commented Mar 3, 2014

Sorry for the dup, I fried my repo and it's no longer updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants