-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added module examples to the Naming Conventions page as well as a table ... #482
Conversation
…le for folder naming conventions. Signed-off-by: Alexander Mays <alex@astonishdesign.com>
this looks fantastic, thanks! |
can you ad an example with nested folders? |
Sure thing, I'm going to continue to refactor them a bit, that was just something I was able to put out on Friday evening after work. Alexander Mays On Feb 10, 2014, at 9:32 AM, Stefan Penner notifications@github.com wrote:
|
sounds good, can you make a checklist so i know when you are done, so i know when i can merge? |
We can disregard this pull request and I'll submit a new one later today. Alexander Mays On Feb 10, 2014, at 9:50 AM, Stefan Penner notifications@github.com wrote:
|
As far as sweeping changes to the docs, what is your recommendation? I feel like it could be consolidated/rearranged in a more coherent manner. Alexander Mays On Feb 10, 2014, at 9:50 AM, Stefan Penner notifications@github.com wrote:
|
We opted for dasherized file names in #218, didn't we? As Stefan put it: One naming convention for file and module names. I'd really like that anyway. |
Now I had a closer look at your changes. It seems that it's just mixed. The resolver supports both naming conventions but it would be nice to stick with dashes in the docs. What do you think? Thanks for your effort btw :) |
+1 for consistency |
@alexmays you can reuse existing pull requests? this keeps noise down |
@alexmays ping, would love to get this rebase + in. |
I apologize, I still have some pending changes. I'll get this done after work tonight! |
Sorry for the dup, I fried my repo and it's no longer updating. |
...for folder naming conventions.
Just some explicit examples, could probably use some re-touching.
Signed-off-by: Alexander Mays alex@astonishdesign.com