extract load-initializers and use it in test-loader

[ghedamat]

#579 added initalizers autoloading (thanks!)

This PR attempts to extract that into a separate module (maybe the path should be different) and adds the same behaviour to test loader so that they're available during tests.

test-loader.js seems the right place to do it as it has to happen only once (App.destroy() won't remove previously added initializers, nor it should)

Let me know if this makes sense or if I'm just missing a much better way to deal with it.

Thanks!

[stefanpenner]

see: https://github.com/stefanpenner/ember-cli/blob/master/blueprint/tests/helpers/start-app.js#L18

[ghedamat]

@stefanpenner I'm sorry I guess I'm not getting it right.

from my tests if we change https://github.com/stefanpenner/ember-app-kit/blob/master/tests/helpers/start-app.js#L19 to use https://github.com/stefanpenner/ember-app-kit/blob/master/app/main.js

and we call startApp() in every single acceptance test like
https://github.com/stefanpenner/ember-app-kit/blob/master/tests/acceptance/index-test.js
and
https://github.com/stefanpenner/ember-app-kit/blob/master/tests/acceptance/helper-test.js

then the initializers will be added twice and you'll get a failed assertion...

[ghedamat]

@stefanpenner, I did a bit more digging and I believe that this is broken also in ember-cli

if you checkout this commit you'll see that the tests are failing
ghedamat@a91a726

I also tried to isolate the scenario in a jsbin http://emberjs.jsbin.com/nisod/1/edit

as said earlier App.destroy() won't remove already assigned initializers but calling bootApp
within startApp (https://github.com/stefanpenner/ember-cli/blob/master/blueprint/app/main.js) will try to add them again and trigger the error.

let me know if I got this completely wrong!

thanks!

[stefanpenner]

@ghedamat you are correct. A solution would be for https://github.com/stefanpenner/ember-cli/blob/master/blueprint/app/main.js#L4 to be require(prefix + '/app')['default'].extend();

Another would be to add initializers https://github.com/stefanpenner/ember-cli/blob/master/blueprint/app/app.js#L14 to the App Class only once, here.

Likely extracting the initializer loading code to a vendor'd lib

[ghedamat]

@stefanpenner updated, I hope I got the AMD syntax right, let me know if this is the right approach or what should I change.

[stefanpenner]

LGTM, I'm not sure if I am a fan of the module name, but i am unsure what else to call it.

Once we decide on the name, I will extract it into its own project, so we can share it between EAK + CLI

(cc @rjackson @twkul)

[ghedamat]

@stefanpenner agreed, I'm happy to rename to anything.

the original code was bootApp but that doesn't seem to fit either now.

let me know

[fsmanuel]

@ghedamat don't forget to add !/vendor/load-initializers.js to .gitignore

[fsmanuel]

@ghedamat forget about it. we don't need that if it's a package

[ghedamat]

@fsmanuel I added it in the meantime, in case @stefanpenner wants to merge this before extracting the package.

thanks for noticing!

[stefanpenner]

i've added you both to: https://github.com/stefanpenner/ember-load-initializers if you can prep that package that would be great. I would love to merge it as a package

[ghedamat]

@stefanpenner I'll give it a shot shortly

[ghedamat]

@stefanpenner I pushed a first version to https://github.com/stefanpenner/ember-load-initializers
and updated this PR to use that package

I ended up naming it ember/load-initializers in the AMD module, let me know what you think

[stefanpenner]

@ghedamat if you have time to submit to cli, that would be great.

[ghedamat]

@stefanpenner will do shortly

[fsmanuel]

@ghedamat 👍