Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static css compiler broken (0.1.x regression) #2215

Closed
kanongil opened this issue Oct 6, 2014 · 10 comments · Fixed by #2301
Closed

Static css compiler broken (0.1.x regression) #2215

kanongil opened this issue Oct 6, 2014 · 10 comments · Fixed by #2301

Comments

@kanongil
Copy link
Contributor

kanongil commented Oct 6, 2014

The update of broccoli-file-mover to 0.4.x (841ee8c), is a breaking change since it no longer copies other files from the input tree (see rwjblue/broccoli-file-mover#12).

This changes causes the static css compilation in https://github.com/stefanpenner/ember-cli/blob/master/lib/preprocessors.js#L53 to only copy the app.css to the output, and ignore all other files from the app/styles directory.

@rwjblue
Copy link
Member

rwjblue commented Oct 6, 2014

I cannot recall why I made it not copy to begin with. Seems to be an obvious mistake at this point...

@marcemira
Copy link

Same here... i got other css files on folders, included via @import.. It doesn't copy them to dist/assets

@denispeplin
Copy link

Same issue, ember-cli 0.1.1

@vinilios
Copy link

vinilios commented Oct 7, 2014

same here. any hacky workaround for this ? Tried to downgrade the file-mover in ember-cli package but another error occured, i guess due to api changes.

@kanongil
Copy link
Contributor Author

kanongil commented Oct 7, 2014

@rwjblue What is the path forward on this? Do you plan to change broccoli-file-mover or will we have to find a workaround in ember-cli. Eg. apply move + remove + merge?

@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2014

I plan to fix broccoli-file-mover.

@marcemira
Copy link

👍

2 similar comments
@vinilios
Copy link

vinilios commented Oct 7, 2014

👍

@SamvelRaja
Copy link

👍

@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2014

Fixed by #2301 (and tests added to ensure no future regressions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants