Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emblem #2357

Closed
alwaysautumn opened this issue Oct 20, 2014 · 17 comments
Closed

Emblem #2357

alwaysautumn opened this issue Oct 20, 2014 · 17 comments

Comments

@alwaysautumn
Copy link

Hey,

I followed the documentation for implementing emblem with ember cli, but I really can't get it working. I'm getting errors once I change the extension to .embl or .emblem. Let me know what I can do to help out, and if you'd like me to submit a pull request.

Austin

@jakecraige
Copy link
Member

You need to at least say what errors you're getting..

@stefanpenner
Copy link
Contributor

if you can submit a PR to fix you problem, that would be great.

@alwaysautumn
Copy link
Author

$ ember serve
version: 0.1.2
Livereload server on port 35729
Serving on http://0.0.0.0:4200/
File: emblem/templates/application.js
Line 1: Unexpected identifier
Error: Line 1: Unexpected identifier
at throwError (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:2579:21)
at throwUnexpected (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:2623:13)
at expect (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:2650:13)
at parseArrayInitialiser (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:2783:21)
at parsePrimaryExpression (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:3076:20)
at /Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:5661:38
at trackLeftHandSideExpressionAllowCall (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:5563:61)
at parsePostfixExpression (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:3214:20)
at /Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:5661:38
at parseUnaryExpression (/Users/Austin/Desktop/coding/javascript_immersion_projects/jsi-embercli/emblem/node_modules/ember-cli/node_modules/broccoli-es6-concatenator/node_modules/es6-module-transpiler/dist/es6-module-transpiler.js:3278:16)

@jakecraige
Copy link
Member

Do you .js file in your templates folder? That may be emblem putting it there but I want to make sure.

@alwaysautumn
Copy link
Author

I'll try to resolve it, but any help you guys could offer would be much appreciated. I'm getting the error after creating a new project with ember-cli, running npm install --save-dev broccoli-emblem-compiler, and changing the application.hbs extension to either *.embl or *.emblem.

I tried the same set up on another machine over lunch and had the same issue.

Thanks for getting back to me!

@alwaysautumn
Copy link
Author

No .js files in the templates folder. Looks clean.

@stefanpenner
Copy link
Contributor

broccoli-emblem-compiler looks pretty old (lots of broccoli changes since then), I wonder if it is just not working anymore

@wbyoung
Copy link

wbyoung commented Oct 20, 2014

@stefanpenner any tips on getting the broccoli-emblem-compiler up to date?

@stefanpenner
Copy link
Contributor

I would compare it to the hbs compiler and see if anything looks out of date

@alwaysautumn
Copy link
Author

OK, I'll take a look. Thanks.

@stefanpenner
Copy link
Contributor

Sorry I can't be more helpful this evening.

@alwaysautumn
Copy link
Author

It's all good! I appreciate the response. I'll let you know if I come up with a solution.

@inDream
Copy link
Contributor

inDream commented Oct 21, 2014

I'm using broccoli-emblem-compiler and it works.
May be there're errors in your template?

@cascalheira
Copy link

I had this problem here also. I traced it down to the broccoli-emblem-compiler node modules. The same version of the module now installs the handlebars 2.0 module instead of the 1.3 version of it.
It also installs the 1.9 alpha version of ember-template-compiler instead of the older stabler version.

I just copied an "broccoli-emblem-compiler" folder i had on another computer and it's working now.

@dunnkers
Copy link

This is the exact problem (@cascalheira). Probably an ember-template-compiler update messed it up, since broccoli-emblem-compiler has an 'any higher' dependency on this (^1.5.0).

I can confirm that manually downgrading the ember-template-compiler in the broccoli-emblem-compiler package to 1.7.0-beta.1 makes it work again.

@rwjblue
Copy link
Member

rwjblue commented Oct 22, 2014

@cascalheira / @dunnkers - Thanks for tracking this down, can y'all open an issue on the broccoli-emblem-compiler repo for this?

Closing as not an ember-cli issue...

@rwjblue rwjblue closed this as completed Oct 22, 2014
@cascalheira
Copy link

Emblem.js was updated to support handlebars 2.0.

If you want to use Ember canary on Ember-cli, you can use the broccoli-emblem-compiler temporary fork i made: https://github.com/cascalheira/broccoli-emblem-compiler

It's just a 'dirty' way to solve this meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants