Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember init does not respect app-name #395

Closed
jbrown opened this issue Apr 19, 2014 · 2 comments · Fixed by #491
Closed

ember init does not respect app-name #395

jbrown opened this issue Apr 19, 2014 · 2 comments · Fixed by #491
Assignees
@stefanpenner
Labels
bug

Comments

@jbrown
Copy link
Contributor

jbrown commented Apr 19, 2014

https://github.com/stefanpenner/ember-cli/blob/master/lib/commands/init.js#L19
@stefanpenner
Copy link
Contributor

good catch, we are actually doing a poor job of referencing "the project" throughout the codebase.

We have a concept of, project and use it here

We should use the current project model instance throughout the app, and stop leaking "process.cwd" and other ad-hoc solutions all over the place.

@stefanpenner
Copy link
Contributor

related: https://github.com/stefanpenner/ember-cli/blob/master/lib/preprocessors.js#L3-L4

@stefanpenner stefanpenner mentioned this issue Apr 23, 2014
Closed
@rwjblue rwjblue mentioned this issue Apr 28, 2014
Merged
homu added a commit that referenced this issue Jul 29, 2016
@homu
Auto merge of #6120 - ember-cli:greenkeeper-github-2.4.0, r=nathanham…
76af66e 
…mond

github@2.4.0 breaks build ⚠️

Hello lovely humans,

[github](https://www.npmjs.com/package/github) just published its new version 2.4.0.

<table>
  <tr>
    <th align=left>
      State
    </th>
    <td>
      Failing tests ⚠️
    </td>
  </tr>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      github
    </td>
  </tr>
  <tr>
    <th align=left>
      New version
    </td>
    <td>
      2.4.0
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      devDependency
    </td>
  </tr>
</table>

This version is **covered** by your **current version range** and after updating it in your project **the build kept failing**.

**It looks like your project, in its current form, is malfunctioning** and this update didn’t really change that. I don’t want to leave you in the dark about updates though. I recommend you get your project passing and then check the impact of this update again.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and while I’m just a bot, there is a group of people who are happy to teach me new things. [Let them know](https://github.com/greenkeeperio/greenkeeper/issues/new).

Good luck with your project ✨

You rock!

🌴

---
The new version differs by 35 commits .

- [`044870f`](octokit/octokit.js@044870f) <code>bump to 2.4.0 and update changelog</code>
- [`7d3caaf`](octokit/octokit.js@7d3caaf) <code>small adjustment to renderMarkdown apidoc</code>
- [`1e1a49a`](octokit/octokit.js@1e1a49a) <code>Merge branch 'add-render-markdown-example' into pull-request-403</code>
- [`167af7d`](octokit/octokit.js@167af7d) <code>add render markdown example</code>
- [`94e9609`](octokit/octokit.js@94e9609) <code>Avoid parsing non json data</code>
- [`1db50dd`](octokit/octokit.js@1db50dd) <code>small readme formatting change</code>
- [`8e5cc67`](octokit/octokit.js@8e5cc67) <code>add preview apis section to readme (#402)</code>
- [`eddf674`](octokit/octokit.js@eddf674) <code>add github pages preview stuff (#401)</code>
- [`aa885e0`](octokit/octokit.js@aa885e0) <code>bump to 2.3.0 and update changelog</code>
- [`d03ce74`](octokit/octokit.js@d03ce74) <code>add wyandotte to list of preview header vals</code>
- [`272fa07`](octokit/octokit.js@272fa07) <code>issue locking/unlocking is official</code>
- [`a525af8`](octokit/octokit.js@a525af8) <code>multiple assignees api is now official</code>
- [`1057911`](octokit/octokit.js@1057911) <code>add protected branch api endpoints (#398)</code>
- [`50d9214`](octokit/octokit.js@50d9214) <code>destroy socket on timeout (#395)</code>
- [`b8dfa69`](octokit/octokit.js@b8dfa69) <code>bump to 2.2.0 and update changelog</code>

There are 35 commits in total. See the [full diff](octokit/octokit.js@20f35dd...044870f).

---
This pull request was created by [greenkeeper.io](https://greenkeeper.io/).

<sub>Tired of seeing this sponsor message? ⚡ `greenkeeper upgrade`</sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanpenner stefanpenner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the current package.json name value for ember init. rwjblue/ember-cli
2 participants
@stefanpenner @jbrown