Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not tracking build times correctly #642

Closed
stefanpenner opened this issue May 7, 2014 · 6 comments
Closed

not tracking build times correctly #642

stefanpenner opened this issue May 7, 2014 · 6 comments

Comments

@stefanpenner
Copy link
Contributor

I suspect we not issuing the right events for rebuild times:

https://github.com/stefanpenner/ember-cli/blob/master/lib/utilities/build-watcher.js#L18-L35

(cc @twokul )
@rwjblue
Copy link
Member

rwjblue commented May 7, 2014

@stefanpenner - Just to confirm, are you referring to build times (via ember build) or rebuild times (when running ember server)?

@stefanpenner stefanpenner changed the title no tracking build times correctly not tracking build times correctly May 7, 2014
@stefanpenner
Copy link
Contributor Author

both, they should show up as "page speed times"

@stefanpenner
Copy link
Contributor Author

status?

@twokul
Copy link
Contributor

twokul commented Jun 6, 2014

I made some fixes to leek. Tracking time seems to be tricky, reports do not reflect requests right away. Still looking into it.

@twokul
Copy link
Contributor

twokul commented Jun 6, 2014

fixed via #934

@twokul twokul closed this as completed Jun 6, 2014
@stefanpenner
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @rwjblue @twokul