Update --dry-run, add --skip-npm and --skip-bower #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously --dry-run meant a couple different things. In the `init` command it meant “don’t run npm install or bower install”. In the `generate` command it meant “don’t overwrite any existing files”. This patch changes the behaviour of the flag in both places. --dry-run now only ever means “don’t write *any* files” Two new flags are introduced for `new` and `init: --skip-npm --skip-bower Their behaviour is hopefully self-explanatory. Addresses ember-cli#1199
|
@rondale-sc would be great to get your eyes on this patch too. |
| @@ -37,7 +37,7 @@ describe('Acceptance: ember generate', function() { | |||
| }); | |||
|
|
|||
| function initApp() { | |||
| return ember(['init', 'my-app', '--dry-run']); | |||
| return ember(['init', 'my-app', '--skip-npm', '--skip-bower']); | |||
There was a problem hiding this comment.
I am apparently blind (or shouldn't comment on issues until after coffee). This does exactly what I asked above.
|
Looks good! This inconsistency had pestered me before, thanks for tackling it. I only had one small question, but other than that I'm 👍. |
rwjblue
added a commit
that referenced
this pull request
Jun 30, 2014
Update --dry-run, add --skip-npm and --skip-bower
Closed
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously --dry-run meant a couple different things.
In the
initcommand it meant “don’t run npm install or bower install”.In the
generatecommand it meant “don’t overwrite any existing files”.This patch changes the behaviour of the flag in both places.
--dry-run now only ever means “don’t write any files”
Two new flags are introduced for
newandinit:--skip-npm
--skip-bower
Their behaviour is hopefully self-explanatory.
Addresses #1199