Change behaviour of standardLocals in blueprints for slashes #1278
Conversation
|
Looks good to me. The test coverage for generators/blueprints is certainly thorough 😄 |
| assertFile('tests/unit/models/foo/bar-test.js', { | ||
| contains: [ | ||
| "import { test, moduleForModel } from 'ember-qunit';", | ||
| "moduleForModel('foo/bar', 'FooBar'" |
There was a problem hiding this comment.
Why not just use the dasherization full name here?
There was a problem hiding this comment.
This test is testing for what the actual output is - are you suggesting changing the output from the command or the test? (I'm assuming you're talking about the description here)
|
Are we waiting for something on this, or just not gotten around to it yet? I realize not all the tests necessarily reflect the desired outcome from generate commands for directories, they only show what this change does. Would it be better if I removed the tests that don't reflect what we want in the end? We should do more work on directories in generators, but changing these variables is a pretty good first step. |
|
havent had a chance to review. |
|
Can you add a changelog entry, squash, and rebase? |
Conflicts: CHANGELOG.md
|
Done |
Change behaviour of standardLocals in blueprints for slashes
This PR strips the slash from some of the standard locals in blueprints.
An example of before and after with the command
ember generate view foo-bar/baz-qux:dasherizedModuleNamefoo-bar/baz-quxfoo-bar/baz-quxclassifiedModuleNameFooBar/bazQuxFooBarBazQuxcamelizedModuleNamefooBar/bazQuxfooBarBazQuixdasherizedModuleNameis left alone, as that is used for the generation of the files themselves.See the new tests for details on how this affects all the different included generators. (It is most obvious in the generated tests).
classifiedPackageNameshould probably also be changed, but I don't know any usecases for it right now.