LiveReload filter patterns #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also solve the |
bcardarella
changed the title
|
This should be good to go now that broccolijs/broccoli-sane-watcher#10 has been released |
| name: 'broccoli watcher', | ||
| message: 'live-reload' | ||
| }); | ||
| var canTrigger = this.project.liveReloadFilterPatterns.reduce(function(bool, pattern) { |
There was a problem hiding this comment.
It seems that this needs to either be defaulted or we need to guard against liveReleadFilterPatterns being undefined. A default project does not have one specified (at least not that I see in this PR) which means this would break live reload for existing apps.
There was a problem hiding this comment.
doh, that is supposed to have a default. Adding...
Will allow a Project to add its own patterns for which the LiveReload server can use to ignore certain file changes.
|
@rwjblue should be all good now |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow a Project to add its own patterns for which the LiveReload
server can use to ignore certain file changes.
This PR is waiting on broccolijs/broccoli-sane-watcher#10