Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize entity name before getting locals #1717

Merged
merged 1 commit into from Aug 24, 2014

Conversation

hlindset
Copy link
Contributor

Fixes #1713 for blueprints http-proxy, http-mock, app and addon.

The generators were trying to access and modify options.entity.name in the locals hook, which was called before normalizeEntityName, causing them to err out.

$ ember g addon
version: 0.0.40-master-84e031b5c0
Cannot call method 'replace' of undefined

Is the test I added sufficient?

@jgwhite
Copy link
Contributor

jgwhite commented Aug 22, 2014

Thanks for this, looks good. Could you squash and add an entry to the changelog?

@jgwhite
Copy link
Contributor

jgwhite commented Aug 22, 2014

As an aside — we could really do with better documentation of the normalizeEntityName hook. Would you be interested in writing some into the gh-pages branch?

@hlindset
Copy link
Contributor Author

Squashed.

Sure, I can write some documentation for normalizeEntityName later this week.

@jgwhite
Copy link
Contributor

jgwhite commented Aug 24, 2014

Build had a slow fail. Rebuilding. Will merge when green.

rwjblue added a commit that referenced this pull request Aug 24, 2014
Normalize entity name before getting locals
@rwjblue rwjblue merged commit cf7aab6 into ember-cli:master Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If you do not specify a name, ember g http-proxy gives a vague error.
3 participants