[Bugfix] this.pickFiles did not exist on addon #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,7 +212,7 @@ Addon.prototype.jshinting = function() { | |||
| }; | |||
|
|
|||
| Addon.prototype.addonJsFiles = function(tree) { | |||
| var files = pickFiles(tree, { | |||
| var files = this.pickFiles(tree, { | |||
| srcDir: '/', | |||
There was a problem hiding this comment.
May need to call this._requireBuildPackages() method here first.
There was a problem hiding this comment.
isn't it in the constructor?
There was a problem hiding this comment.
ah its not, should it be in the constructor instead?
There was a problem hiding this comment.
If it were in the constructor we would pay the initialize hit even when the addon does nothin build related.
There was a problem hiding this comment.
Also would not allow using ember-cli to build ember either (due to es6ify issue indicated in the original issue).
There was a problem hiding this comment.
where do we eagerly instantiate the add-on?
- i'll split the up as you recommended.
stefanpenner
force-pushed
the
pick-files-fix
branch
3 times, most recently
from
eec13be
to
2fee486
Compare
stefanpenner
force-pushed
the
pick-files-fix
branch
from
2fee486
to
12c507d
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 5, 2014
[Bugfix] this.pickFiles did not exist on addon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.