Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup http-proxy blueprint #1896

Merged
merged 1 commit into from
Sep 6, 2014
Merged

cleanup http-proxy blueprint #1896

merged 1 commit into from
Sep 6, 2014

Conversation

stefanpenner
Copy link
Contributor

  • Proxy makes jshint unhappy “redefines global”
  • add missing semi-colon
  • require it on-demand, as to not negatively impact cli boot

@rwjblue
Copy link
Member

rwjblue commented Sep 6, 2014

https://github.com/stefanpenner/ember-cli/blob/cleanup-proxies/tests/acceptance/generate-test.js#L813-L816 needs to be updated

@stefanpenner
cleanup http-proxy blueprint
eea2d06 
* Proxy makes jshint unhappy “redefines global”
* add missing semi-colon
* require it on-demand, as to not negatively impact cli boot
* add missing path
@stefanpenner
Copy link
Contributor Author

@rwjblue c, was working on it.. Should be green now

Also using this generated output in my app so it should be ok. Hopefully soon @trek or someone can help with functional tests of the proxy generated output.

@stefanpenner
Copy link
Contributor Author

feel free to merge when green time-for-dinner

rwjblue added a commit that referenced this pull request Sep 6, 2014
@rwjblue
Merge pull request #1896 from stefanpenner/cleanup-proxies
5b7a462 
cleanup http-proxy blueprint
@rwjblue rwjblue merged commit 5b7a462 into master Sep 6, 2014
@rwjblue rwjblue deleted the cleanup-proxies branch September 6, 2014 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanpenner @rwjblue