Ensure that things loaded by server/index.js override addons. #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Express will always process the first matching middleware. A couple examples where this is bad: * If a proxy was setup, it is always hit before any http-mocks you have setup (since it is itself an addon). * If you want to serve static content (or another express middleware) from `server/index.js` you could never handle requests with an accept header including HTML. If you did, it would have hit the history state addon and just served up `app/index.html`. In general, it is our policy that the application will always "trump" addon code.
rwjblue
force-pushed
the
app-wins-express
branch
from
0a162a5
to
96a3649
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 16, 2014
Ensure that things loaded by server/index.js override addons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express will always process the first matching middleware.
A couple examples where this is bad:
server/index.jsyou could never handle requests with an accept header including HTML. If you did, it would have hit the history state addon and just served upapp/index.html.In general, it is our policy that the application will always "trump" addon code.
Closes #1997.