Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use url.parse instead of manually checking baseURL. #2088

Merged
merged 1 commit into from Sep 23, 2014
Merged

Use url.parse instead of manually checking baseURL. #2088

merged 1 commit into from Sep 23, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 23, 2014

Closes #2085.

@rwjblue rwjblue mentioned this pull request Sep 23, 2014
Closed
@rwjblue
Use url.parse instead of manually checking baseURL.
6e6781d 
```
> url.parse('localhost/').href
'localhost/'
> url.parse('app://localhost/').href
'app://localhost/'
> url.parse('https://localhost/foo/').href
'https://localhost/foo/'
```
rwjblue added a commit that referenced this pull request Sep 23, 2014
@rwjblue
Merge pull request #2088 from rwjblue/use-url-parse
76570e0 
Use url.parse instead of manually checking baseURL.
@rwjblue rwjblue merged commit 76570e0 into ember-cli:master Sep 23, 2014
@rwjblue rwjblue deleted the use-url-parse branch September 23, 2014 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base tag for a node-webkit app
2 participants
@rwjblue @abuiles