Git based app blueprints #2103
Git based app blueprints #2103
Conversation
|
NICE! |
| }) | ||
| }); | ||
| }).catch(function(err){ | ||
| throw err; |
There was a problem hiding this comment.
Ah, just leftover from dev. It can go away.
|
looks great, mind adding some tests (so we don't accidentally regress)? |
| @@ -137,6 +137,7 @@ | |||
| "rimraf": "^2.2.8", | |||
| "rsvp": "^3.0.13", | |||
| "semver": "^3.0.1", | |||
| "temp": "^0.8.1", | |||
There was a problem hiding this comment.
No real objection here, but can we consolidate on a single tmp library? We currently are using tmp-sync (testing) and quick-temp (used in broccoli processes)...
There was a problem hiding this comment.
but why only have one? We should not discriminate, NPM is all about including all possible libraries for a task!
There was a problem hiding this comment.
quick-temp puts them in ./tmp but I don't want to pollute user space with temp folders for app generation. temp uses whatever the system identifies as a system-wide temp location and cleans up after itself. quick-temp makes sense for generation once the app exists, but I think it's icky before the app exists.
There was a problem hiding this comment.
What we really need to do is write our own temp module that does exactly what we need...
trek
force-pushed
the
git-app-blueprints
branch
4 times, most recently
from
188a3d4
to
03f27aa
Compare
| @@ -16,6 +17,19 @@ var allowedWorkOptions = { | |||
| everywhere: true | |||
| }; | |||
|
|
|||
| // extend nopt to recognize 'gitUrl' as a type | |||
| nopt.typeDefs.gitUrl = { | |||
trek
force-pushed
the
git-app-blueprints
branch
from
03f27aa
to
b8a9e7f
Compare
|
@trek LGTM, let me know when it travis is happy: https://travis-ci.org/stefanpenner/ember-cli/builds/36371014 |
trek
force-pushed
the
git-app-blueprints
branch
2 times, most recently
from
53a4917
to
5db3b4f
Compare
|
Looks good now. Needed to add the git checkout to the slow tests: https://travis-ci.org/stefanpenner/ember-cli/builds/36435142 |
trek
force-pushed
the
git-app-blueprints
branch
3 times, most recently
from
37564dd
to
032a9bf
Compare
Extends `ember new'`s --blueprint option to accept git remotes in either git@someservice.com:app-blueprint-test.git or https://someservice.com/trek/app-blueprint-test.git style git remote urls.
trek
force-pushed
the
git-app-blueprints
branch
from
032a9bf
to
9471422
Compare
|
Fixed a typo https://travis-ci.org/stefanpenner/ember-cli/builds/36496366 is still good |
WIP: Git based app blueprints
Extends
ember new's--blueprintoption to accept git remotes in eithergit@someservice.com:app-blueprint-test.gitorhttps://someservice.com/trek/app-blueprint-test.gitstyle git remote urls.Not a huge fan of how this is tested, but short of mocking I can't think of any way to truly test without doing an actual
git clone