Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure line + col information is also displayed #2246

Merged
merged 1 commit into from
Oct 8, 2014
Merged

ensure line + col information is also displayed #2246

merged 1 commit into from
Oct 8, 2014

Conversation

stefanpenner
Copy link
Contributor

  • tests
  • acceptance tests passing again. (about 9 simple output related acceptance tests are failing)
  • i think we should extract the error logging logic, share it and test it in 1 place.

@stefanpenner stefanpenner mentioned this pull request Oct 7, 2014
Closed
@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2014

LGTM - Real smoke tests will be annoying, but possible. We can merge this and add an issue to create smoke tests for build failures during ember build --watch and ember serve if you'd rather. I will get them added, just can't do it now....

@stefanpenner stefanpenner force-pushed the more-errors branch 3 times, most recently from 9ddaf59 to 06d2e35 Compare October 7, 2014 13:29
rwjblue
rwjblue reviewed Oct 7, 2014
View reviewed changes
tests/unit/tasks/server/livereload-server-test.js
@@ -110,6 +110,15 @@ describe('livereload-server', function() {
assert.equal(trackCount, 1);
});

function BuildError(input){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in lib/errors/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/fixtures/errors ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we can share this between the build task aswell

@stefanpenner
Copy link
Contributor Author

i need to head out to work, will try and finish this up as soon as i get there.

@stefanpenner stefanpenner mentioned this pull request Oct 7, 2014
Closed
@stefanpenner
Copy link
Contributor Author

@rwjblue many tests and refactorings.

@rwjblue
Copy link
Member

rwjblue commented Oct 8, 2014

👍

rwjblue added a commit that referenced this pull request Oct 8, 2014
@rwjblue
Merge pull request #2246 from stefanpenner/more-errors
8972992 
ensure line + col information is also displayed
@rwjblue rwjblue merged commit 8972992 into master Oct 8, 2014
@rwjblue rwjblue deleted the more-errors branch October 8, 2014 02:13
This was referenced Oct 8, 2014
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanpenner @rwjblue @abuiles