Add --watcher=polling option to Test command. #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
|
|
||
| _Builder: Builder, | ||
| _Watcher: Watcher, |
There was a problem hiding this comment.
lets pass these in via the contructor rather then requiring them in this file at all.
There was a problem hiding this comment.
Updated to set the default values on init.
There was a problem hiding this comment.
Updated again to remove the leading underscore (as mentioned in another comment).
rwjblue
force-pushed
the
allow-test-server-polling
branch
2 times, most recently
from
49a02b9
to
bc6c490
Compare
rwjblue
force-pushed
the
allow-test-server-polling
branch
from
bc6c490
to
428e917
Compare
rwjblue
added a commit
that referenced
this pull request
Oct 12, 2014
Add --watcher=polling option to Test command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2099.