Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #2588 Add extra content-for hooks #2592

Merged
merged 3 commits into from
Nov 30, 2014
Merged

Close #2588 Add extra content-for hooks #2592

merged 3 commits into from
Nov 30, 2014

Conversation

jackmatt2
Copy link
Contributor

Added extra content-for hooks that allow you to inject code at the bottom of the head and body tags from an ember-cli addon.

* `{{content-for 'head-footer'}}`
* `{{content-for 'test-head-footer'}}`
* `{{content-for 'body-footer'}}`
* `{{content-for 'test-body-footer'}}`

No explicit tests as there we no existing ones for the other hooks that I could see.

@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2014

👍

@jackmatt2
Copy link
Contributor Author

@rwjblue it is not clear from here where I should update the changelog. Do I do it on my local repo after creating the pull request?

@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2014

@jackmatt2 - The changelog is updated prior to release, you do not need to update it in your PR.

@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2014

BUT, feel free if you want to ;) It should go under the master heading in a section for applications.

@jackmatt2
Copy link
Contributor Author

Anyone know why the build failed? I only changed 2 html files ...

@stefanpenner
Copy link
Contributor

its green: https://travis-ci.org/stefanpenner/ember-cli/builds/42532516

AppVeyor is our windows CI, and isn't passing yet.

stefanpenner added a commit that referenced this pull request Nov 30, 2014
Close #2588 Add extra content-for hooks
@stefanpenner stefanpenner merged commit d184aba into ember-cli:master Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants