Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config/environments.js to control options to provide to the application. #370

Merged
merged 1 commit into from
Apr 15, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 15, 2014

No description provided.

@stefanpenner
Copy link
Contributor

ENV.APP.* ?

@rwjblue
Copy link
Member Author

rwjblue commented Apr 15, 2014

Sure, I wasn't super happy about the actual name, but I think the concept is solid.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 15, 2014

Updated to ENV.APP.

@stefanpenner
Copy link
Contributor

i wonder if we should push modulePrefix in like this aswell ?

@MajorBreakfast
Copy link
Contributor

Use EmberENV while your at it.

(BTW I'm not a big fan of all caps. I'd call it appOptions.)

stefanpenner added a commit that referenced this pull request Apr 15, 2014
Use config/environments.js to control options to provide to the application.
@stefanpenner stefanpenner merged commit 3767fe7 into ember-cli:master Apr 15, 2014
@rwjblue rwjblue deleted the prod-versions branch April 15, 2014 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants