Create own tree for tests files and avoid testing files on ENV=productio... #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,14 +134,29 @@ EmberApp.prototype.styles = memoize(function() { | |||
| return preprocessCss(this.appAndDependencies(), this.name + '/styles', '/assets'); | |||
| }); | |||
|
|
|||
| EmberApp.prototype.testsFiles = memoize(function() { | |||
There was a problem hiding this comment.
I don't want to tie people here to qunit, so rather that qunitFiles -> testFiles... (could be confusing)
There was a problem hiding this comment.
Should it be testFiles (currently it is testsFiles), as the others seem to only pluralize the files part...
There was a problem hiding this comment.
@rjackson makes sense, updating.
|
update commit message: [fixes #409] |
|
@stefanpenner done. |
|
@rjackson thanks for pointing that out, fixed. |
stefanpenner
added a commit
that referenced
this pull request
Apr 23, 2014
Create own tree for tests files and avoid testing files on ENV=productio...
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n (closes #409).