Fix package.json preprocessor dependencies not being included in the registry. #703
Conversation
|
re-running the failed test this looks great, thanks! |
| @@ -9,12 +10,15 @@ describe('Plugin Loader', function() { | |||
|
|
|||
| beforeEach(function() { | |||
| pkg = { | |||
| dependencies: { | |||
| 'broccoli-emblem': 'latest' | |||
There was a problem hiding this comment.
Is this used in the test? I could be missing it, but looks like it is added, but not used for an assertion...
There was a problem hiding this comment.
I think you're right. I don't think it actually is
On Monday, May 12, 2014, Robert Jackson notifications@github.com wrote:
In tests/unit/preprocessors/registry-test.js:
@@ -9,12 +10,15 @@ describe('Plugin Loader', function() {
beforeEach(function() {
pkg = {
dependencies: {'broccoli-emblem': 'latest'Is this used in the test? I could be missing it, but looks like it is
added, but not used for an assertion...—
Reply to this email directly or view it on GitHubhttps://github.com//pull/703/files#r12563450
.
Thanks,
Jake Craige
Poetic Systems
675 Bering Dr. Suite 725
Houston, TX 77057
(281) 531-4060 - Office
There was a problem hiding this comment.
can this be ammended? Would love to merge
There was a problem hiding this comment.
I kinda figured you would keep this, and just add an assertion to confirm emblem is found.
There was a problem hiding this comment.
@rjackson updated. that does make more sense, lol
|
Can you add a CHANGELOG entry, and squash? |
|
(looks great, BTW) |
|
@rjackson all done. and thanks! |
jakecraige
changed the title
…ncies-and-dependencies Fix package.json preprocessor dependencies not being included in the registry.
No description provided.