Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testem version to fix assertions #714

Merged
merged 1 commit into from
May 14, 2014

Conversation

joesteele
Copy link
Contributor

When looking at ember-cli, the first thing I did was see what testing was like out of the box. I started out with a simple assertion on true which fails.

tests/unit/truth-test.js

import { test } from 'ember-qunit';

test('true is not false', function() {
  expect(2);
  equal(1, 2, 'these numbers are not equal');
  equal(true, false, 'true is not false');
});

It turns out this was an issue with testem and the default tap reporter which has now been fixed.

(I wasn't sure how to add this type of test directly to ember-cli or I would have included it in the pull request.)

@stefanpenner
Copy link
Contributor

thanks!

Tricky to test, but likely falls into improved acceptance tests. Likely adding a more complex app's tests to our own tests.

stefanpenner added a commit that referenced this pull request May 14, 2014
Update testem version to fix  assertions
@stefanpenner stefanpenner merged commit 426732f into ember-cli:master May 14, 2014
@rwjblue
Copy link
Member

rwjblue commented May 14, 2014

Thanks @joesteele!

rwjblue added a commit that referenced this pull request May 14, 2014
@joesteele
Copy link
Contributor Author

👍 thanks for the project! It's pretty slick!

simonexmachina added a commit to simonexmachina/ember-cli that referenced this pull request May 20, 2014
* 'master' of https://github.com/stefanpenner/ember-cli:
  Create templates/components directory in blueprint.
  Add CHANGELOG entry for ember-cli#758.
  Update broccoli-jshint.
  If project name is app, just return styles.
  Use EMBER_ENV if specified.
  Add `assets/vendor.css` to `tests/index.html`.
  Allow testem port to be specified.
  Load vendor.css from index.html.
  Update CHANGELOG.md
  bump v0.0.28 🎉
  Update CHANGELOG for ember-cli#714.
  Sort dependencies using npm install --save
  update testem version to fix  assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants