Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that features can be enabled via config/environment. #958

Merged
merged 1 commit into from
Jun 9, 2014
Merged

Ensure that features can be enabled via config/environment. #958

merged 1 commit into from
Jun 9, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 9, 2014

Fixes #945.

@rwjblue rwjblue mentioned this pull request Jun 9, 2014
Closed
@stefanpenner
Copy link
Contributor

ah, this changed in ember?

@rwjblue
Copy link
Member Author

rwjblue commented Jun 9, 2014

EmberENV is looked at before ENV as of 1.5.0 (so yes), but we also changed (in ember-cli) so that we are using window.MyProjectENV.

Previously, we just always used window.ENV which just happened to work without additional configuration due to re-using the same keys in the hash, but that was non-obvious.

stefanpenner added a commit that referenced this pull request Jun 9, 2014
@stefanpenner
Merge pull request #958 from rjackson/ensure-features-can-be-enabled
4b928e8 
Ensure that features can be enabled via config/environment.
@stefanpenner stefanpenner merged commit 4b928e8 into ember-cli:master Jun 9, 2014
@stefanpenner stefanpenner deleted the ensure-features-can-be-enabled branch June 9, 2014 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature flag not working
2 participants
@rwjblue @stefanpenner