Allow opting out of ES3SafeFilter. #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +55,7 @@ function EmberApp(options) { | |||
| this.hinting = options.hasOwnProperty('hinting') ? options.hinting : !isProduction; | |||
|
|
|||
| this.options = defaults(options, { | |||
| es3Safe: true, | |||
There was a problem hiding this comment.
small comment here please:
// for some large projects, you may want to uncomment this (for now)feel free to wordsmith
There was a problem hiding this comment.
OK, I'll add to the Brocfile.js with that comment then.
|
This should be |
We were forced to move the `ES3SafeFilter` step to only operate on transpiled ES6 output (since it fails on some ES6 module syntax). Sadly, this means that we are reprocessing the ENTRIE app/ tree for every rebuild. Which is **SLOW**!!
|
@WMeldon - Good catch, updated. |
|
LGTM |
rwjblue
added a commit
that referenced
this pull request
Jun 10, 2014
Allow opting out of ES3SafeFilter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were forced to move the
ES3SafeFilterstep to only operate on transpiled ES6 output (since it fails on some ES6 module syntax).Sadly, this means that we are reprocessing the ENTRIE app/ tree for every rebuild. Which is SLOW!!