Update for fastboot 1.0

[scottmessinger]

This isn't working yet :-( But I think the basics are there. Anyone know why I'm seeing this error message?

Error: ENOENT: no such file or directory,
open '/app/tmp/broccoli_merge_trees-output_path-3ahQH1aD.tmp/app/node_modules/ember-fetch/assets/fastboot-fetch.js'

[scottmessinger]

Part of ember-fastboot/ember-cli-fastboot#387

[kratiahuja]

Hey Scott! I'll take a look at that error by end of day and let you know.

[kratiahuja]

The reason you are seeing the error is because of this line. This will give you an absolute path. The fastboot manifest takes the relative path to the dist or tmp directory from it is going to serve the assets. The reason being it serves everything off a relative path that is given to it on boot.

Therefore, this asset needs to be part of the app build assets (ie in dist).

My recommendation would be:

1. Move the contents of assets/fastboot-fetch.js to public/fastboot-fetch.js and delete assets/fastboot-fetch.js
2. Once it is in public folder, ember-cli will automatically build it and put it in dist/ember-fetch/fastboot-fetch.js after the build.
3. You can update this function to just be:

updateFastBootManifest: function(manifest) {
  manifest.vendorFiles.push('ember-fetch/fastboot-fetch.js');
  return manifest;
}

See the similar changes here.

Also see the migration guide here

[scottmessinger]

@kratiahuja Thanks! That fixed it!!!

[kratiahuja]

LGTM. @scottmessinger thanks for tackling this. Can you confirm you tested all three scenarios listed here: https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c#testing-guidelines ? Once you confirm, this should be good to be merged. Ideally we should add fastboot tests, but I'll open an issue in this repo.

[kratiahuja]

@scottmessinger pinging again if you have cycles to test this? If not, I'll test this over the weekend and merge.

[scottmessinger]

@kratiahuja I'm sorry! I haven't gotten a chance to test the three scenarios and I'm not sure when I'll get a chance to do it thoroughly :-(

[kratiahuja]

No worries, I'll test it over the weekend.

[kratiahuja]

Confirmed this works with the beta and rc builds. Merging this...

[kratiahuja]

Thanks @scottmessinger !

[kratiahuja]

@stefanpenner I don't think I am an npm owner. Can we please do a 2.0.1 release?

[kratiahuja]

@stefanpenner can we release 2.0.1?

[stefanpenner]

@kratiahuja you are now an owner.

[stefanpenner]

released as v2.1.0 🎉

[cibernox]

However I'm getting Cannot read property 'then' of undefined when I use fetch in fastboot mode. Has anyone see the same thing?

[scottmessinger]

@cibernox I haven't seen that -- it makes me wonder if the fetch library that ember-fetch depends on is loading.