Depedency Clean-up in csproj #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Microsoft.Extensions.Options instead of indirect dependency from Microsoft.Extensions.Logging
cristipufu
approved these changes
Aug 8, 2020
altso
reviewed
Oct 30, 2020
| <PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options" Version="3.1.6" /> |
There was a problem hiding this comment.
Shouldn't the version be 2.2.0 (same as other M.E.* packages)?
There was a problem hiding this comment.
Oh yes. I gonna have to check that, but you could be right.
There was a problem hiding this comment.
I didn't have any issues. I was planning on using this library in my project and was going through the source code to understand the scope/features/dependencies and noticed this inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that there are some depedency import which can be simplified. The idea is to have the absolute minimum of external nugets referenced here (e.g. use Microsoft.Extensions.Loggging.Abstractions instead of Microsoft.Extensions.Logging as we only use abstractions in this library).