Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent calling virtual method RegisterResolvers inside constructor o… #170

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Prevent calling virtual method RegisterResolvers inside constructor o… #170

merged 1 commit into from
Dec 1, 2020

Conversation

melmi
Copy link
Contributor

@melmi melmi commented Dec 1, 2020

Prevent calling virtual method RegisterResolvers inside constructor of RateLimitConfiguration

cristipufu
cristipufu approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@cristipufu cristipufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@cristipufu cristipufu merged commit 08442d3 into stefanprodan:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristipufu cristipufu cristipufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@melmi @cristipufu