Added MonitorMode option to the rate limit rules #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! |
cristipufu
approved these changes
Jun 14, 2021
|
Thank you! |
|
Hiya! Also in very much need for this feature so was wondering if you had a rough ETA for the next release :) @cristipufu? (and thank you @m-gug for implementing this 😍) |
|
Amazing! Thank you so much! 🙏 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the RateLimitRules you can now set "MonitorMode" to true (default is false).
When set to true exceeding requests won't fail, but they are logged like they have failed.
I think that should also solve #112