Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caddy to v2.2.1 #207

Closed
wants to merge 5 commits into from
Closed

Update caddy to v2.2.1 #207

wants to merge 5 commits into from

Conversation

KonstTz
Copy link

@KonstTz KonstTz commented Jan 2, 2021

Updating caddy to official v2.2.1 in order to fix issue 203
This pull request will also close Feature 206

Copy link
Collaborator

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually somewhat concerned that this will break more instances of dockprom than it will fix.

Having said that please apply the following changes before we consider changing over.

README.md Outdated
@@ -350,3 +352,6 @@ To run the grafana container as `user: 104` change your `docker-compose.yml` lik
labels:
org.label-schema.group: "monitoring"
```
## Updating Caddy to v2

Perform a `docker exec -it caddy caddy hash-password` in order to generate a hash for your new password. Don't forget to update `ADMIN_PASSWORD`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Perform a `docker exec -it caddy caddy hash-password` in order to generate a hash for your new password. Don't forget to update `ADMIN_PASSWORD`
Perform a `docker run --rm caddy caddy hash-password --plaintext 'ADMIN_PASSWORD'` in order to generate a hash for your new password.
Ensure that you replace `ADMIN_PASSWORD` with your actual password and update the reference in the `docker-compose.yml` for the caddy container.

Your example assumes the user has a running a container named caddy.
This will allow a user to generate their password non-interactively too.

README.md Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@nightah nightah mentioned this pull request Jan 15, 2021
@hfyeomans hfyeomans mentioned this pull request Mar 3, 2021
KonstTz and others added 2 commits March 18, 2021 15:19
Co-authored-by: Amir Zarrinkafsh <nightah@me.com>
Co-authored-by: Amir Zarrinkafsh <nightah@me.com>
@nightah
Copy link
Collaborator

nightah commented Apr 6, 2021

Closed by #216.

@nightah nightah closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants