Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Update README about read/write endpoints #17

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Apr 19, 2019

Hey! Thanks a lot for developing and sharing podinfo. This is so handy ☺️

I was following https://github.com/stefanprodan/k8s-podinfo/blob/master/docs/1-deploy.md#using-the-helm-chart and helm test failed.

The cause seemed like changes in two endpoints. POST /write seems to have changed to POST /store, and GET /read/{hash} to GET /store/{hash}. Here's the fix just for README, according to my observation :)

// I should have fixed /scripts/ping.sh as well so that helm test passes, but had no time!

I was following https://github.com/stefanprodan/k8s-podinfo/blob/master/docs/1-deploy.md#using-the-helm-chart and `helm test` failed.

The cause seemed like changes in two endpoints. `POST /write` seems to have changed to `POST /store`, and `GET /read/{hash}` to `GET /store/{hash}`. Here's the fix according to my observation :)
@mumoshu
Copy link
Contributor Author

mumoshu commented Apr 19, 2019

I would fix /scripts/ping.sh to something like curl -sS ${PODINFO_SVC}/store/$(curl -sSd 'test' ${PODINFO_SVC}/store | jq -r .hash) |grep test. But obviously this doesn't work as we don't have jq installed in the test container.

https://github.com/stefanprodan/k8s-podinfo/blob/92114c05c942af47c6c75d9ed31b7dfd29f9c33e/charts/podinfo/templates/tests/storage.yaml#L39-L41

@stefanprodan
Copy link
Owner

stefanprodan commented Apr 19, 2019

Yes I'll change the image to giantswarm/tiny-tools that has curl and jq.

@stefanprodan stefanprodan merged commit d1b77c9 into stefanprodan:master Apr 19, 2019
@mumoshu mumoshu deleted the patch-1 branch April 19, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants