Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment on sleep during graceful shutdown #320

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add comment on sleep during graceful shutdown #320

merged 1 commit into from
Nov 15, 2023

Conversation

duxinxiao
Copy link
Contributor

@duxinxiao duxinxiao commented Nov 15, 2023 •
edited by stefanprodan

Fix: #319

stefanprodan
stefanprodan approved these changes Nov 15, 2023
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @duxinxiao

@stefanprodan stefanprodan merged commit 73fcdbe into stefanprodan:master Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion regarding comments on graceful shutdown
2 participants
@duxinxiao @stefanprodan