This repository has been archived by the owner on May 6, 2021. It is now read-only.
✨ Docker Swarm mode with Traefik v2 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiangolo
commented
May 24, 2020
| * Set and export an environment variable with the tag used by Traefik public to filter services (by default, it's `traefik-public`): | ||
|
|
||
| ```bash | ||
| export TRAEFIK_PUBLIC_TAG=traefik-public |
There was a problem hiding this comment.
I have never used this to override the Traefik tag, I don't know anyone that has. And I'm making it "fixed" by default, in DockerSwarm.rocks and in the project generators (for FastAPI), so it's easier to simplify that and remove the optional env var to reduce complexity/noise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Docker Compose file for Docker Swarm mode with Traefik v2.
I just updated everything at DockerSwarm.rocks to use Traefik v2, this performs the equivalent upgrade here.