fix(engine): return the cue values merge error if non nil #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a rather confusing error while making changes to some
values.cue
default definitions, which led me to investigate (happy to open an accompanying issue if that is useful):The change proposed returns the cue Values error if not nil, before attempting to write out the generated value.
The problem is in my
values.cue
file. It was that I had put a concrete list in my default values that wasn't compatible with my changes in the overriden values. For example:I figured this had something to do with CUE merging my default and supplied values files together.
The reference
./values.cue:2:9
made no sense relative to my values files, so I assumed it was referring to some other intermediate generated file which led me to find the module builder. When I put in a debug line to print out thefinalVal
I found in had the contents (literall bottom value with a comment):Changing the builder to return the value error if not nil results in
timoni
failing like so: