Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set label names in plot_recovery() #102

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

levolz
Copy link
Contributor

@levolz levolz commented Sep 13, 2023

qol change to allow to change label names if wanting something other than "ground truth" / "estimated"

stefanradev93 and others added 2 commits September 11, 2023 22:53
Add summary_dim attribute to transformers
qol change to allow to change label names if wanting something other than "ground truth" / "estimated"
@levolz levolz changed the title set_label names in plot_recovery() set label names in plot_recovery() Sep 13, 2023
@stefanradev93
Copy link
Owner

Pls add new arguments in the docstring of the function too.

@stefanradev93
Copy link
Owner

Pls also pull requests for Development, no direct pulls to master.

@levolz levolz changed the base branch from master to Development September 13, 2023 21:16
@levolz
Copy link
Contributor Author

levolz commented Sep 13, 2023

changed now - re: docstrings, n_col & n_row are not documented yet

@stefanradev93
Copy link
Owner

Nice. 10x, need to document those too.

@levolz
Copy link
Contributor Author

levolz commented Sep 13, 2023

Wasn't sure about style, though - instead of

xlabel :
XXX
ylabel :
YYY

you could (for brevity) do

xlabel, ylabel :
XXX, YYY

@stefanradev93
Copy link
Owner

As per convention, each arg gets its own line with type, default and a new line for description (see existing, looks nice when rendered).

@stefanradev93 stefanradev93 merged commit c76304a into stefanradev93:Development Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants