Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check c++ version based on msvc version #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

terrorfisch
Copy link

See #6

@terrorfisch
Copy link
Author

Strange. The tests do not fail on my machine and dnot seem connected to the code changes.

@stefanseefeld
Copy link
Owner

I have rewritten the scheduler (using Python async), so these failures should be a thing of the past.
I don't agree with this PR, though: While I understand that MSVC may actually support C++11 now, I think it's best to preserve the semantics of these specific checks. If that doesn't yield the information you want you may think of other checks that test specific C++ features, rather than only that version macro. Else we get into the muddy waters of having to decide what it actually means to support C++11, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants