Setup visual and a11y tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
2 times, most recently
from
3dd71f0
to
9218239
Compare
This was
linked to
issues
Jul 25, 2022
uLucasFraga
approved these changes
Jul 26, 2022
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
2 times, most recently
from
4f44699
to
de9cd04
Compare
|
Severest isn't ready for Happo haha |
|
@uLucasFraga indeed, Safari is a pain 😅 |
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
from
de9cd04
to
6e55cc9
Compare
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
from
6e55cc9
to
e96a03d
Compare
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
from
e96a03d
to
910642e
Compare
|
LGTM! <3 |
stefanteixeira
force-pushed
the
setup-visual-regression-and-a11y-tests
branch
from
910642e
to
0ccd98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up a sample a11y test with axe-playwright and a couple of visual regression tests using happo-playwright integration. Also, configured a CI job for visual regression tests and enabled Happo app in the repository.
How to test
yarn installtests/e2e/create-user.e2e.test.js(it's skipped as it will always fail, since the component has a11y issues)yarn test:visual(you will need an account on Happo to run it locally)Checklist
concise-feature-descriptionmain(if not, rebase it)