Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmget could return a future #95

Closed

Conversation

vince94320
Copy link

No description provided.

@vince94320
Copy link
Author

Not sure If this is required, but I ended to have some failing tests in sidekiq.cr because it uses pipelined calls with hmget and they should return a Redis::Future

@stefanwille
Copy link
Owner

Hi Vince, yes, this is a bug. The fix is different though: commands.cr relies on type inference from the underlying command_execution to get the return types. I have put a fix in d65deae

Thank you for your effort.

@stefanwille
Copy link
Owner

Closing in favor of d65deae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants